simplesystems/website
simplesystems/website
1
0
Fork 0
Code Issues 18 Pull Requests Actions Wiki Activity

blog: Code Reviews #33

New Issue
Open
opened 2022-01-14 19:47:17 +00:00 by jeff · 0 comments
jeff commented 2022-01-14 19:47:17 +00:00
Owner
Copy Link

https://google.github.io/eng-practices/review/
Comment/Type name mismatch
Code as comment
Debugging code/prints
Meaningless names
Be sure to look through codebase and address repeats of corrections
Missing/potentially missed Close()
Code simplification (replace for loop with append(x, list...))
Redundant work (creating a db connection per query)
References to local filesystem
Too large of a change

https://google.github.io/eng-practices/review/ Comment/Type name mismatch Code as comment Debugging code/prints Meaningless names Be sure to look through codebase and address repeats of corrections Missing/potentially missed Close() Code simplification (replace for loop with append(x, list...)) Redundant work (creating a db connection per query) References to local filesystem Too large of a change
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
  
Dev Ready

   
Issue Not Ready

   
Tech Debt
No Label
Dev Ready
Issue Not Ready
Tech Debt
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: simplesystems/website#33
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?