simplesystems/website
simplesystems/website
1
0
Fork 0
Code Issues 18 Pull Requests Actions Wiki Activity

close the nav via 'going back' in the browser #47

Merged
jeff merged 2 commits from back-button-close-nav into master 2022-04-25 16:38:54 +00:00
Conversation 0 Commits 2 Files Changed 1 +3 -2
steverusso commented 2022-04-25 00:51:46 +00:00
Contributor
Copy Link

This PR makes it so that opening the nav used a hash in the browser's location. This way, we can program the 'back' action in the browser to close the nav.

Haven't tested on mobile yet, might be a bit quirky.

This PR makes it so that opening the nav used a hash in the browser's location. This way, we can program the 'back' action in the browser to close the nav. Haven't tested on mobile yet, might be a bit quirky.
steverusso added 1 commit 2022-04-25 00:51:47 +00:00
steverusso added 1 commit 2022-04-25 12:38:17 +00:00
jeff approved these changes 2022-04-25 16:38:45 +00:00
jeff merged commit 0c70a13a3a into master 2022-04-25 16:38:54 +00:00
jeff deleted branch back-button-close-nav 2022-04-25 16:39:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jeff
Labels
Clear labels
  
Dev Ready

   
Issue Not Ready

   
Tech Debt
No Label
Dev Ready
Issue Not Ready
Tech Debt
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: simplesystems/website#47
No description provided.
Delete Branch "back-button-close-nav"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?